Repository navigation
refactor: use NotEqualsFilter for single-field negations - #255
Closed
Vin Le (vienthuong) wants to merge 1 commit into
Closed
Vin Le (vienthuong) wants to merge 1 commit into
Vin Le (vienthuong) wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #255 +/- ##
============================================
+ Coverage 65.37% 65.46% +0.09%
Complexity 4790 4790
============================================
Files 654 654
Lines 21760 21722 -38
============================================
- Hits 14225 14221 -4
+ Misses 7535 7501 -34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
Same simplification as shopware/shopware#22866:
NotFilter(AND|OR, [EqualsFilter(...)])with a single filter is whatNotEqualsFilteralready is.2. What does this change do, exactly?
Replaces 23 hand-built single-field negations with
NotEqualsFilter. Negations ofnullon association paths (a.b) are left alone.3. Describe each step to reproduce the issue or behaviour.
Not applicable. Existing tests cover the changed code; they were not run locally.
5. Checklist